From: Gervase Markham <gerv@mozilla.org>
Date: Wed, 16 Apr 2014 19:26:49 +0000 (+0200)
Subject: Bug 995988: can_edit_product() can throw warnings if SUM() returns NULL
X-Git-Tag: bugzilla-4.5.3~6
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=060fa9003b9177a73f02ba5ea561bb5be306c74a;p=thirdparty%2Fbugzilla.git

Bug 995988: can_edit_product() can throw warnings if SUM() returns NULL
r=LpSolit a=justdave
---

diff --git a/Bugzilla/User.pm b/Bugzilla/User.pm
index 1f0acee3d6..5cebe728b7 100644
--- a/Bugzilla/User.pm
+++ b/Bugzilla/User.pm
@@ -906,7 +906,7 @@ sub can_edit_product {
                            CASE WHEN canedit = 1 AND group_id IN ($groups) THEN 1 ELSE 0 END AS cnt_group_member
                     FROM group_control_map
                     WHERE product_id = $prod_id) AS p");
-        return ($cnt_can_edit == 0 or $cnt_group_member > 0);
+        return (!$cnt_can_edit or $cnt_group_member);
     }
     else {
         # For and-groups, a user needs to be in all canedit groups. Therefore