From: Amos Jeffries <squid3@treenet.co.nz>
Date: Sun, 14 Jun 2009 12:51:10 +0000 (+1200)
Subject: Author: fancyrabbit <fancyrabbit@gmail.com>
X-Git-Tag: SQUID_3_0_STABLE16~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0624912f12d205cdd273224372fd412d7458cdeb;p=thirdparty%2Fsquid.git

Author: fancyrabbit <fancyrabbit@gmail.com>
Bug 2672: cacheMemMaxSize 32-bit overflow during snmpwalk

snint is 32-bits. Unwrapped the code casts int64 to int32 before
reducing the base unit size to MB.
---

diff --git a/src/snmp_agent.cc b/src/snmp_agent.cc
index 8577550408..3e1104c4df 100644
--- a/src/snmp_agent.cc
+++ b/src/snmp_agent.cc
@@ -118,13 +118,13 @@ snmp_confFn(variable_list * Var, snint * ErrP)
 
         case CONF_ST_MMAXSZ:
             Answer = snmp_var_new_integer(Var->name, Var->name_length,
-                                          (snint) Config.memMaxSize >> 20,
+                                          (snint) (Config.memMaxSize >> 20),
                                           ASN_INTEGER);
             break;
 
         case CONF_ST_SWMAXSZ:
             Answer = snmp_var_new_integer(Var->name, Var->name_length,
-                                          (snint) Store::Root().maxSize() >> 10,
+                                          (snint) (Store::Root().maxSize() >> 10),
                                           ASN_INTEGER);
             break;