From: Jim Jagielski <jim@apache.org>
Date: Tue, 8 Jan 2019 13:12:34 +0000 (+0000)
Subject: This just got me. I upgraded macOS to Mojave (w/ latest Xcode) and I always build... 
X-Git-Tag: 2.5.0-alpha2-ci-test-only~2224
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=062899679ddc22ca7a6dc772bed5069a2221c8df;p=thirdparty%2Fapache%2Fhttpd.git

This just got me. I upgraded macOS to Mojave (w/ latest Xcode) and I always build w/ maintainer-mode. The problem is that libxml2 will include various unicode/*.h files that have C++ type comments, which causes building to fail (due to Werror). Work around this.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1850745 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/modules/filters/config.m4 b/modules/filters/config.m4
index 3a3cf3d4d0d..082363a0bc7 100644
--- a/modules/filters/config.m4
+++ b/modules/filters/config.m4
@@ -114,6 +114,10 @@ AC_DEFUN([FIND_LIBXML2], [
     if test -n "${xml2_path}" ; then
       ac_cv_libxml2=yes
       XML2_INCLUDES="${xml2_path}"
+      dnl libxml2 includes unicode/*.h files which uses C++ comments
+      if test "$GCC" = "yes"; then
+        APACHE_ADD_GCC_CFLAG([-Wno-error=comment])
+      fi
     else
       ac_cv_libxml2=no
     fi