From: Kai Mueller <15907922+kasium@users.noreply.github.com> Date: Thu, 24 Jun 2021 13:08:50 +0000 (+0000) Subject: Fix missing None handling of Table.prefixes X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0638723e43f156889fc4ae19dbf96f586ca2ae53;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git Fix missing None handling of Table.prefixes --- diff --git a/lib/sqlalchemy/sql/schema.py b/lib/sqlalchemy/sql/schema.py index 221d49db9a..f80d4989c2 100644 --- a/lib/sqlalchemy/sql/schema.py +++ b/lib/sqlalchemy/sql/schema.py @@ -659,7 +659,7 @@ class Table(DialectKWArgs, SchemaItem, TableClause): for evt, fn in listeners: event.listen(self, evt, fn) - self._prefixes = kwargs.pop("prefixes", []) + self._prefixes = kwargs.pop("prefixes", []) or [] self._extra_kwargs(**kwargs) diff --git a/test/sql/test_metadata.py b/test/sql/test_metadata.py index 9e02530525..4efcf607d1 100644 --- a/test/sql/test_metadata.py +++ b/test/sql/test_metadata.py @@ -5540,3 +5540,7 @@ class CopyDialectOptionsTest(fixtures.TestBase): m2 = MetaData() t2 = t1.to_metadata(m2) # make a copy self.check_dialect_options_(t2) + + def test_prefixes_set_to_none(self): + table = Table("foo", Column("bar", Integer), prefixes=None) + assert table._prefixes == []