From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Wed, 1 Mar 2023 21:23:40 +0000 (+1300)
Subject: talloc: Remove unneeded va_copy()
X-Git-Tag: talloc-2.4.1~959
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=064d8a3d1236dfdada1e2256d6feb804353f0d27;p=thirdparty%2Fsamba.git

talloc: Remove unneeded va_copy()

We don't use 'ap' again after this.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
---

diff --git a/lib/talloc/talloc.c b/lib/talloc/talloc.c
index 72f3eb729ad..530bad896ab 100644
--- a/lib/talloc/talloc.c
+++ b/lib/talloc/talloc.c
@@ -2678,9 +2678,7 @@ static inline char *__talloc_vaslenprintf_append(char *s, size_t slen,
 	s = talloc_realloc(NULL, s, char, slen + alen + 1);
 	if (!s) return NULL;
 
-	va_copy(ap2, ap);
-	vsnprintf(s + slen, alen + 1, fmt, ap2);
-	va_end(ap2);
+	vsnprintf(s + slen, alen + 1, fmt, ap);
 
 	_tc_set_name_const(talloc_chunk_from_ptr(s), s);
 	return s;