From: Ben Darnell <ben@bendarnell.com>
Date: Mon, 23 Jan 2012 18:20:35 +0000 (-0800)
Subject: Document curl_httpclient empty password fix.
X-Git-Tag: v2.2.0~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=067e465b9267d8065647020a3e764d7c6b18179e;p=thirdparty%2Ftornado.git

Document curl_httpclient empty password fix.

Accept None as auth_password in simple_httpclient for consistency with
curl_httpclient.
---

diff --git a/tornado/simple_httpclient.py b/tornado/simple_httpclient.py
index ad5b7e098..376d410c5 100644
--- a/tornado/simple_httpclient.py
+++ b/tornado/simple_httpclient.py
@@ -257,7 +257,7 @@ class _HTTPConnection(object):
             username, password = parsed.username, parsed.password
         elif self.request.auth_username is not None:
             username = self.request.auth_username
-            password = self.request.auth_password
+            password = self.request.auth_password or ''
         if username is not None:
             auth = utf8(username) + b(":") + utf8(password)
             self.request.headers["Authorization"] = (b("Basic ") +
diff --git a/website/sphinx/releases/next.rst b/website/sphinx/releases/next.rst
index fa940c895..aec080bf9 100644
--- a/website/sphinx/releases/next.rst
+++ b/website/sphinx/releases/next.rst
@@ -32,6 +32,8 @@ Backwards-incompatible changes
   responses with no content, or empty ``POST``/``PUT`` response bodies.
 * `SimpleAsyncHTTPClient` now supports 303 and 307 redirect codes.
 * `tornado.curl_httpclient` now accepts non-integer timeouts.
+* `tornado.curl_httpclient` now supports basic authentication with an
+  empty password.
 
 ``tornado.httpserver``
 ~~~~~~~~~~~~~~~~~~~~~~