From: Francis Dupont <fdupont@isc.org>
Date: Sat, 29 Jun 2019 13:31:19 +0000 (+0200)
Subject: [676-add-support-for-server-tags-in-the-cb_cmds-hooks-library] Addressed comments
X-Git-Tag: Kea-1.6.0-beta2~151
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=06826b5e5c55218f98c68fdbf353ef33c12a4d6f;p=thirdparty%2Fkea.git

[676-add-support-for-server-tags-in-the-cb_cmds-hooks-library] Addressed comments
---

diff --git a/src/lib/dhcpsrv/testutils/test_config_backend_dhcp4.cc b/src/lib/dhcpsrv/testutils/test_config_backend_dhcp4.cc
index d6eb91dac1..222b3b0f81 100644
--- a/src/lib/dhcpsrv/testutils/test_config_backend_dhcp4.cc
+++ b/src/lib/dhcpsrv/testutils/test_config_backend_dhcp4.cc
@@ -188,6 +188,7 @@ TestConfigBackendDHCPv4::getModifiedOptions4(const db::ServerSelector& /* server
 StampedValuePtr
 TestConfigBackendDHCPv4::getGlobalParameter4(const db::ServerSelector& server_selector,
                                              const std::string& name) const {
+    auto candidate = StampedValuePtr();
     const auto& index = globals_.get<StampedValueNameIndexTag>();
     auto global_range = index.equal_range(name);
     for (auto global_it = global_range.first; global_it != global_range.second;
@@ -196,16 +197,13 @@ TestConfigBackendDHCPv4::getGlobalParameter4(const db::ServerSelector& server_se
         for (auto tag : tags) {
             if ((*global_it)->hasServerTag(ServerTag(tag))) {
                 return (*global_it);
+            } else if ((*global_it)->hasAllServerTag()) {
+                candidate = *global_it;
             }
         }
     }
 
-    auto global_all_it = index.find(name);
-    if ((global_all_it != index.end()) && ((*global_all_it)->hasAllServerTag())) {
-        return (*global_all_it);
-    }
-
-    return (StampedValuePtr());
+    return (candidate);
 }
 
 
diff --git a/src/lib/dhcpsrv/testutils/test_config_backend_dhcp6.cc b/src/lib/dhcpsrv/testutils/test_config_backend_dhcp6.cc
index 5d64898755..6e183b39fe 100644
--- a/src/lib/dhcpsrv/testutils/test_config_backend_dhcp6.cc
+++ b/src/lib/dhcpsrv/testutils/test_config_backend_dhcp6.cc
@@ -187,6 +187,7 @@ TestConfigBackendDHCPv6::getModifiedOptions6(const db::ServerSelector& /* server
 StampedValuePtr
 TestConfigBackendDHCPv6::getGlobalParameter6(const db::ServerSelector& server_selector,
                                              const std::string& name) const {
+    auto candidate = StampedValuePtr();
     const auto& index = globals_.get<StampedValueNameIndexTag>();
     auto global_range = index.equal_range(name);
     for (auto global_it = global_range.first; global_it != global_range.second;
@@ -196,15 +197,12 @@ TestConfigBackendDHCPv6::getGlobalParameter6(const db::ServerSelector& server_se
             if ((*global_it)->hasServerTag(ServerTag(tag))) {
                 return (*global_it);
             }
+        } else if ((*global_it)->hasAllServerTag()) {
+            candidate = *global_it;
         }
     }
 
-    auto global_all_it = index.find(name);
-    if ((global_all_it != index.end()) && ((*global_all_it)->hasAllServerTag())) {
-        return (*global_all_it);
-    }
-
-    return (StampedValuePtr());
+    return (candidate);
 }