From: Amos Jeffries <squid3@treenet.co.nz>
Date: Sat, 24 Nov 2012 03:40:43 +0000 (-0700)
Subject: Various memory leaks in configuration parsing
X-Git-Tag: SQUID_3_3_0_2~19
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=06ba721bff3700fb3b5161cffe050aef81686649;p=thirdparty%2Fsquid.git

Various memory leaks in configuration parsing

This lot are all small issues derived from allocating new memory and
assigning to a pointer already pointing at previous allocation, or
passing xstrdup() output to a caller which does not directly hold the
passed memory.
 Both cases will disappear once we clean up the string handling in Squid
but for now these still need fixing to avoid leaking memory.

 Detected by Coverity Scan. Issues 740430, 740432, 740439.
---

diff --git a/src/adaptation/icap/Options.cc b/src/adaptation/icap/Options.cc
index c792735107..219589c1de 100644
--- a/src/adaptation/icap/Options.cc
+++ b/src/adaptation/icap/Options.cc
@@ -205,8 +205,11 @@ void Adaptation::Icap::Options::TransferList::parse(const String &buf, bool &fou
     while (strListGetItem(&buf, ',', &item, &ilen, &pos)) {
         if (ilen == 1 && *item == '*')
             foundStar = true;
-        else
-            add(xstrndup(item, ilen+1));
+        else {
+            const char *tmp = xstrndup(item, ilen+1);
+            add(tmp);
+            xfree(tmp);
+        }
     }
 }
 
diff --git a/src/cache_cf.cc b/src/cache_cf.cc
index c1807b61e2..ebb57a526f 100644
--- a/src/cache_cf.cc
+++ b/src/cache_cf.cc
@@ -594,6 +594,7 @@ parseOneConfigFile(const char *file_name, unsigned int depth)
     cfg_filename = orig_cfg_filename;
     config_lineno = orig_config_lineno;
 
+    xfree(tmp_line);
     return err_count;
 }
 
diff --git a/src/main.cc b/src/main.cc
index a0e91a12b6..8a09993594 100644
--- a/src/main.cc
+++ b/src/main.cc
@@ -543,6 +543,7 @@ mainParseOptions(int argc, char *argv[])
             /** \par l
              * Stores the syslog facility name in global opt_syslog_facility
              * then performs actions for -s option. */
+            xfree(opt_syslog_facility); // ignore any previous options sent
             opt_syslog_facility = xstrdup(optarg);
 
         case 's':