From: Steffan Karger Date: Mon, 28 Nov 2016 14:53:20 +0000 (+0100) Subject: tls_process: don't set variable that's never read X-Git-Tag: v2.4_rc1~14 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=06c54466c86ee3beff9b6cd75f40de5e431d8235;p=thirdparty%2Fopenvpn.git tls_process: don't set variable that's never read Found by the clang static analyzer: the state_change variable is set, but never read afterwards. This code has been like this since 2005, makes sense without setting state_change to true, and has worked fine for the past 11 years. Signed-off-by: Steffan Karger Acked-by: Gert Doering Message-Id: <1480344801-27855-1-git-send-email-steffan.karger@fox-it.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg13260.html Signed-off-by: Gert Doering --- diff --git a/src/openvpn/ssl.c b/src/openvpn/ssl.c index 7347a7871..d9de38000 100644 --- a/src/openvpn/ssl.c +++ b/src/openvpn/ssl.c @@ -2809,7 +2809,6 @@ tls_process (struct tls_multi *multi, RELIABLE_ACK_SIZE, false); *to_link = buf; active = true; - state_change = true; dmsg (D_TLS_DEBUG, "Dedicated ACK -> TCP/UDP"); } #endif