From: Willy Tarreau <w@1wt.eu>
Date: Fri, 10 Oct 2014 12:54:25 +0000 (+0200)
Subject: BUG/MEDIUM: config: avoid skipping disabled proxies
X-Git-Tag: v1.6-dev1~297
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=06cc905813f1858c0606b44d1e271bd0b6a25224;p=thirdparty%2Fhaproxy.git

BUG/MEDIUM: config: avoid skipping disabled proxies

Paul Taylor and Bryan Talbot found that after commit 419ead8 ("MEDIUM:
config: compute the exact bind-process before listener's maxaccept"),
a backend marked "disabled" would cause the next backend to be skipped
and if it was the last one it would cause a segfault.

The reason is that the commit above changed the "while" loop for a "for"
loop but a "continue" statement still incrementing the current proxy was
left in the code for disabled proxies, causing the next one to be skipped
as well and the last one to try to dereference NULL when seeking ->next.

The quick workaround consists in not disabling backends, or adding an
empty dummy one after a disabled section.

This fix must be backported to 1.5.
---

diff --git a/src/cfgparse.c b/src/cfgparse.c
index 72f3d92352..09a0fd3d77 100644
--- a/src/cfgparse.c
+++ b/src/cfgparse.c
@@ -6157,7 +6157,6 @@ int check_config_validity()
 		if (curproxy->state == PR_STSTOPPED) {
 			/* ensure we don't keep listeners uselessly bound */
 			stop_proxy(curproxy);
-			curproxy = curproxy->next;
 			continue;
 		}