From: Miod Vallat <miod.vallat@powerdns.com>
Date: Wed, 9 Jul 2025 19:36:31 +0000 (+0200)
Subject: Remove unused instance members. NFC
X-Git-Tag: rec-5.4.0-alpha0~34^2~12
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=06d539c46beba88697c8c627e57a9a94d564f21f;p=thirdparty%2Fpdns.git

Remove unused instance members. NFC

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
---

diff --git a/modules/lmdbbackend/lmdbbackend.cc b/modules/lmdbbackend/lmdbbackend.cc
index 7aa56af866..fcf675ba16 100644
--- a/modules/lmdbbackend/lmdbbackend.cc
+++ b/modules/lmdbbackend/lmdbbackend.cc
@@ -1738,10 +1738,10 @@ bool LMDBBackend::list(const ZoneName& target, domainid_t /* id */, bool include
   d_getcursor = std::make_shared<MDBROCursor>(d_rotxn->txn->getCursor(d_rotxn->db->dbi));
 
   compoundOrdername co;
-  d_matchkey = co(di.id);
+  std::string match = co(di.id);
 
   MDBOutVal key, val;
-  if (d_getcursor->prefix(d_matchkey, key, val) != 0) {
+  if (d_getcursor->prefix(match, key, val) != 0) {
     d_getcursor.reset();
   }
 
@@ -1797,14 +1797,15 @@ void LMDBBackend::lookupInternal(const QType& type, const DNSName& qdomain, doma
   compoundOrdername co;
   d_getcursor = std::make_shared<MDBROCursor>(d_rotxn->txn->getCursor(d_rotxn->db->dbi));
   MDBOutVal key, val;
+  std::string match;
   if (type.getCode() == QType::ANY) {
-    d_matchkey = co(zoneId, relqname);
+    match = co(zoneId, relqname);
   }
   else {
-    d_matchkey = co(zoneId, relqname, type.getCode());
+    match = co(zoneId, relqname, type.getCode());
   }
 
-  if (d_getcursor->prefix(d_matchkey, key, val) != 0) {
+  if (d_getcursor->prefix(match, key, val) != 0) {
     d_getcursor.reset();
     if (d_dolog) {
       g_log << Logger::Warning << "Query " << ((long)(void*)this) << ": " << d_dtime.udiffNoReset() << " us to execute (found nothing)" << endl;
diff --git a/modules/lmdbbackend/lmdbbackend.hh b/modules/lmdbbackend/lmdbbackend.hh
index 59ddd16675..fdc08f14a8 100644
--- a/modules/lmdbbackend/lmdbbackend.hh
+++ b/modules/lmdbbackend/lmdbbackend.hh
@@ -348,11 +348,7 @@ private:
   static void deleteNSEC3RecordPair(const std::shared_ptr<RecordsRWTransaction>& txn, domainid_t domain_id, const DNSName& qname);
   void writeNSEC3RecordPair(const std::shared_ptr<RecordsRWTransaction>& txn, domainid_t domain_id, const DNSName& qname, const DNSName& ordername);
 
-  bool get_list(DNSZoneRecord& rr);
-  bool get_lookup(DNSZoneRecord& rr);
-  std::string d_matchkey;
   ZoneName d_lookupdomain;
-
   vector<LMDBResourceRecord> d_currentrrset;
   size_t d_currentrrsetpos;
   MDBOutVal d_currentKey;