From: Ben Darnell Date: Sat, 8 Apr 2023 18:25:08 +0000 (+0000) Subject: websocket: Add resolver argument to websocket_connect X-Git-Tag: v6.3.0b1~2^2~1 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=06e97a2f65d77504d8c57edf850b524fab74c1b4;p=thirdparty%2Ftornado.git websocket: Add resolver argument to websocket_connect This is the public interface, but when the resolver argument was added it was only added to the supporting WebSocketClientConnection class. --- diff --git a/docs/releases/v6.3.0.rst b/docs/releases/v6.3.0.rst index 1a5c09749..a5c00a7ce 100644 --- a/docs/releases/v6.3.0.rst +++ b/docs/releases/v6.3.0.rst @@ -94,7 +94,7 @@ Deprecation notices - It is now much faster (no longer quadratic) to receive large messages that have been split into many fragments. -- `.WebSocketClientConnection` now accepts a ``resolver`` parameter. +- `.websocket_connect` now accepts a ``resolver`` parameter. ``tornado.wsgi`` ~~~~~~~~~~~~~~~~ diff --git a/tornado/websocket.py b/tornado/websocket.py index 1d42e10ba..6c3315c98 100644 --- a/tornado/websocket.py +++ b/tornado/websocket.py @@ -1589,6 +1589,7 @@ def websocket_connect( ping_timeout: Optional[float] = None, max_message_size: int = _default_max_message_size, subprotocols: Optional[List[str]] = None, + resolver: Optional[Resolver] = None, ) -> "Awaitable[WebSocketClientConnection]": """Client-side websocket support. @@ -1632,6 +1633,9 @@ def websocket_connect( .. versionchanged:: 5.1 Added the ``subprotocols`` argument. + + .. versionchanged:: 6.3 + Added the ``resolver`` argument. """ if isinstance(url, httpclient.HTTPRequest): assert connect_timeout is None @@ -1653,6 +1657,7 @@ def websocket_connect( ping_timeout=ping_timeout, max_message_size=max_message_size, subprotocols=subprotocols, + resolver=resolver, ) if callback is not None: IOLoop.current().add_future(conn.connect_future, callback)