From: Artem Boldariev <artem@boldariev.com>
Date: Wed, 12 Oct 2022 12:26:06 +0000 (+0300)
Subject: DoH unit test: remove broken remnants of slowdown logic
X-Git-Tag: v9.19.7~70^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=070d373c56c8d7ca4d8cd1c2fff100ca21429b74;p=thirdparty%2Fbind9.git

DoH unit test: remove broken remnants of slowdown logic

This commit removes broken remnants of unit test slowdown logic, which
caused unit test hangs on platforms susceptible to "too many open
files" error, notably OpenBSD.
---

diff --git a/tests/isc/doh_test.c b/tests/isc/doh_test.c
index a36893557e0..fca204c307e 100644
--- a/tests/isc/doh_test.c
+++ b/tests/isc/doh_test.c
@@ -86,8 +86,6 @@ static bool noanswer = false;
 
 static atomic_bool POST = true;
 
-static atomic_bool slowdown = false;
-
 static atomic_bool use_TLS = false;
 static isc_tlsctx_t *server_tlsctx = NULL;
 static isc_tlsctx_t *client_tlsctx = NULL;
@@ -157,9 +155,6 @@ connect_send_cb(isc_nmhandle_t *handle, isc_result_t result, void *arg) {
 error:
 	data.reply_cb(handle, result, NULL, data.cb_arg);
 	isc_mem_putanddetach(&data.mctx, data.region.base, data.region.length);
-	if (result == ISC_R_TOOMANYOPENFILES) {
-		atomic_store(&slowdown, true);
-	}
 }
 
 static void
@@ -729,7 +724,7 @@ doh_connect_thread(void *arg) {
 	 * errors, to prevent a thundering herd problem.
 	 */
 	int_fast64_t active = atomic_fetch_add(&active_cconnects, 1);
-	if (atomic_load(&slowdown) || active > workers) {
+	if (active > workers) {
 		goto next;
 	}
 	connect_send_request(connect_nm, req_url, atomic_load(&POST),