From: Ralf Habacker <ralf.habacker@freenet.de>
Date: Thu, 14 Apr 2016 11:58:13 +0000 (+0200)
Subject: dbus_internal_do_not_use_try_message_data: Calling _dbus_message_loader_get_max_messa... 
X-Git-Tag: dbus-1.11.4~60
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=072cdf11ab4f180523fc77a4892059d0a899a7a2;p=thirdparty%2Fdbus.git

dbus_internal_do_not_use_try_message_data: Calling _dbus_message_loader_get_max_message_size(loader) is only useful for its return value, which is ignored (CID 54725).

Reported by Coverity: CID 54725: Useless call (USELESS_CALL)

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=90021
---

diff --git a/dbus/dbus-message-util.c b/dbus/dbus-message-util.c
index 5acd541ec..a9d4a5110 100644
--- a/dbus/dbus-message-util.c
+++ b/dbus/dbus-message-util.c
@@ -483,7 +483,6 @@ dbus_internal_do_not_use_try_message_data (const DBusString    *data,
   /* check some trivial loader functions */
   _dbus_message_loader_ref (loader);
   _dbus_message_loader_unref (loader);
-  _dbus_message_loader_get_max_message_size (loader);
 
   len = _dbus_string_get_length (data);
   for (i = 0; i < len; i++)