From: Julian Seward <jseward@acm.org>
Date: Fri, 5 Sep 2014 20:38:34 +0000 (+0000)
Subject: iselStmt, case Ist_Dirty: remove pointless conditional.  Spotted by
X-Git-Tag: svn/VALGRIND_3_10_1^2~27
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0786d4a5991cf8e4c7155ff532f1dc01a7385034;p=thirdparty%2Fvalgrind.git

iselStmt, case Ist_Dirty: remove pointless conditional.  Spotted by
Coverity and Florian Krohm.


git-svn-id: svn://svn.valgrind.org/vex/trunk@2945
---

diff --git a/VEX/priv/host_ppc_isel.c b/VEX/priv/host_ppc_isel.c
index f58e1a2d27..91f5620160 100644
--- a/VEX/priv/host_ppc_isel.c
+++ b/VEX/priv/host_ppc_isel.c
@@ -5761,26 +5761,18 @@ static void iselStmt ( ISelEnv* env, IRStmt* stmt, IREndness IEndianess )
       if (d->tmp != IRTemp_INVALID)
          retty = typeOfIRTemp(env->type_env, d->tmp);
 
-      /* Throw out any return types we don't know about. */
+      /* Throw out any return types we don't know about.  The set of
+         acceptable return types is the same in both 32- and 64-bit
+         mode, so we don't need to inspect mode64 to make a
+         decision. */
       Bool retty_ok = False;
-      if (mode64) {
-         switch (retty) {
-            case Ity_INVALID: /* function doesn't return anything */
-            case Ity_V128:
-            case Ity_I64: case Ity_I32: case Ity_I16: case Ity_I8:
-               retty_ok = True; break;
-            default:
-               break;
-         }
-      } else {
-         switch (retty) {
-            case Ity_INVALID: /* function doesn't return anything */
-            case Ity_V128:
-            case Ity_I64: case Ity_I32: case Ity_I16: case Ity_I8:
-               retty_ok = True; break;
-            default:
-               break;
-         }
+      switch (retty) {
+         case Ity_INVALID: /* function doesn't return anything */
+         case Ity_V128:
+         case Ity_I64: case Ity_I32: case Ity_I16: case Ity_I8:
+            retty_ok = True; break;
+         default:
+            break;
       }
       if (!retty_ok)
          break; /* will go to stmt_fail: */