From: Michael Tremer <michael.tremer@ipfire.org>
Date: Fri, 18 Aug 2023 14:11:39 +0000 (+0000)
Subject: jobs: Reset jobs as successful if following jobs succeed
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=079e363cfa0ffb824c3467142af81d374dfcf4f9;p=pbs.git

jobs: Reset jobs as successful if following jobs succeed

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/src/buildservice/jobs.py b/src/buildservice/jobs.py
index 09b6ea3e..170d14ea 100644
--- a/src/buildservice/jobs.py
+++ b/src/buildservice/jobs.py
@@ -621,11 +621,15 @@ class Job(base.DataObject):
 		# Store message
 		self._set_attribute("message", message)
 
-		# Handle any unsuccessful jobs
-		if not success:
-			# Mark as failed
-			self._set_attribute("failed", True)
+		# Mark as failed
+		self._set_attribute("failed", not success)
+
+		# On success, update all repositories
+		if success:
+			await self.build._update_repos()
 
+		# Handle any unsuccessful jobs
+		else:
 			# Notify the owner
 			if self.build.owner:
 				# Send an email
@@ -636,10 +640,6 @@ class Job(base.DataObject):
 					log=await self.tail_log(100),
 				)
 
-		# On success, update all repositories
-		if success:
-			await self.build._update_repos()
-
 		# Propagate any changes to the build
 		return await self.build._job_finished(job=self)