From: Jason Kirtland <jek@discorporate.us>
Date: Wed, 21 May 2008 20:34:59 +0000 (+0000)
Subject: Updated fixmes.
X-Git-Tag: rel_0_5beta1~30
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=07a3b8520b4f1c85e00a5bd963bb4f2a827131de;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

Updated fixmes.
---

diff --git a/lib/sqlalchemy/orm/collections.py b/lib/sqlalchemy/orm/collections.py
index 13204e8c12..0e27641234 100644
--- a/lib/sqlalchemy/orm/collections.py
+++ b/lib/sqlalchemy/orm/collections.py
@@ -715,9 +715,10 @@ def __converting_factory(original_factory):
 
 def _instrument_class(cls):
     """Modify methods in a class and install instrumentation."""
-    # FIXME: more formally document this as a decoratorless/Python 2.3
+
+    # TODO: more formally document this as a decoratorless/Python 2.3
     # option for specifying instrumentation.  (likely doc'd here in code only,
-    # not in online docs.)
+    # not in online docs.)  Useful for C types too.
     #
     # __instrumentation__ = {
     #   'rolename': 'methodname', # ...
@@ -904,8 +905,7 @@ def _list_decorators():
 
     def append(fn):
         def append(self, item, _sa_initiator=None):
-            # FIXME: example of fully inlining __set and adapter.fire
-            # for critical path
+            # fully inlining __set and adapter.fire for this critical path
             if _sa_initiator is not False and item is not None:
                 executor = getattr(self, '_sa_adapter', None)
                 if executor: