From: Daan De Meyer <daan.j.demeyer@gmail.com>
Date: Wed, 22 Jan 2025 10:08:39 +0000 (+0100)
Subject: ci: Centralize package installation in unit-tests job
X-Git-Tag: v25~12^2~6
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=07b9a006525558a612fb78dcef2e89cbbdb0ef96;p=thirdparty%2Fmkosi.git

ci: Centralize package installation in unit-tests job

Also get rid of the microsoft-prod.list hack by just not running
apt-get update anymore which avoids the need to remove the microsoft
repositories.
---

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index a8c05c8fd..068c532c8 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -16,10 +16,7 @@ jobs:
 
       - name: Install
         run: |
-          # This is added by default, and it is often broken, but we don't need anything from it
-          sudo rm -f /etc/apt/sources.list.d/microsoft-prod.list
-          sudo apt-get update
-          sudo apt-get install pandoc python3-pytest
+          sudo apt-get install --assume-yes --no-install-recommends pandoc python3-pytest shellcheck
           python3 -m pip install --break-system-packages --upgrade setuptools wheel pip
           python3 -m pip install --break-system-packages codespell mypy reuse ruff
           npm install -g pyright
@@ -96,7 +93,6 @@ jobs:
 
       - name: Run shellcheck on scripts
         run: |
-          sudo apt-get update && sudo apt-get install --no-install-recommends shellcheck
           bash -c 'shopt -s globstar; shellcheck bin/mkosi tools/*.sh'
           bin/mkosi completion bash | shellcheck -