From: Nick Porter <nick@portercomputing.co.uk>
Date: Fri, 7 Mar 2025 12:14:33 +0000 (+0000)
Subject: Revert "value_box_copy() already sets "secret""
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=07bcc3f8fefa87b75a318c88e9f74e64888e6657;p=thirdparty%2Ffreeradius-server.git

Revert "value_box_copy() already sets "secret""

This reverts commit 6f19bf204a8f41f48dc5596675b5ce78ecf42cb0.

The user message could be the user name or the password - so this
sets `secret` based on the attribute being created.
---

diff --git a/src/process/tacacs/base.c b/src/process/tacacs/base.c
index 5c2820e1ae..4dad0bd7e5 100644
--- a/src/process/tacacs/base.c
+++ b/src/process/tacacs/base.c
@@ -796,6 +796,7 @@ RECV(auth_cont)
 #define EXTRACT(_attr) \
 	vp = fr_pair_find_by_da(&request->request_pairs, NULL, attr_tacacs_user_message); \
 	if (!vp) break; \
+	fr_value_box_set_secret(&vp->data, _attr->flags.secret); \
 	if (pair_append_request(&copy, _attr) < 0) break; \
 	if (fr_pair_value_copy(copy, vp) < 0) { \
 		fr_pair_remove(&request->request_pairs, copy); \