From: Volker Lendecke <vl@samba.org>
Date: Fri, 29 Jul 2016 08:54:39 +0000 (+0200)
Subject: lib: Fix a pointless error check
X-Git-Tag: tevent-0.9.30~231
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=07d12d2c71195f8365c02ab599f4793928f9d9e5;p=thirdparty%2Fsamba.git

lib: Fix a pointless error check

According to susv4, addr.s6_addr is a

uint8_t s6_addr[16]

which is always != 0

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
---

diff --git a/source4/lib/socket/socket_ip.c b/source4/lib/socket/socket_ip.c
index d531053add3..6ec525265a7 100644
--- a/source4/lib/socket/socket_ip.c
+++ b/source4/lib/socket/socket_ip.c
@@ -861,7 +861,8 @@ static NTSTATUS ipv6_sendto(struct socket_context *sock,
 		
 		ZERO_STRUCT(srv_addr);
 		addr                     = interpret_addr6(dest_addr->addr);
-		if (addr.s6_addr == 0) {
+		if (memcmp(&addr.s6_addr, &in6addr_any,
+			   sizeof(addr.s6_addr)) == 0) {
 			return NT_STATUS_HOST_UNREACHABLE;
 		}
 		srv_addr.sin6_addr = addr;