From: Jeremy Allison <jra@samba.org>
Date: Fri, 10 Dec 2021 00:45:13 +0000 (-0800)
Subject: s3: smbd: In rename_internals_fsp(), remove unneeded call to check_name().
X-Git-Tag: tdb-1.4.6~341
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=07df94ade1efaa4f261df672ebe6d460063338d6;p=thirdparty%2Fsamba.git

s3: smbd: In rename_internals_fsp(), remove unneeded call to check_name().

All callers have gone through filename_convert(), which has
already called check_name() on the destination.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/source3/smbd/reply.c b/source3/smbd/reply.c
index 2623165966f..1028519b0dc 100644
--- a/source3/smbd/reply.c
+++ b/source3/smbd/reply.c
@@ -7190,11 +7190,6 @@ NTSTATUS rename_internals_fsp(connection_struct *conn,
 	bool case_preserve = (fsp->posix_flags & FSP_POSIX_FLAGS_OPEN) ?
 				true : conn->case_preserve;
 
-	status = check_name(conn, smb_fname_dst_in);
-	if (!NT_STATUS_IS_OK(status)) {
-		return status;
-	}
-
 	status = parent_dirname_compatible_open(conn, smb_fname_dst_in);
 	if (!NT_STATUS_IS_OK(status)) {
 		return status;