From: Marc Hartmayer <mhartmay@linux.vnet.ibm.com>
Date: Fri, 21 Sep 2018 13:02:03 +0000 (+0200)
Subject: virdbus: Report a debug message that dbus_watch_handle() has failed
X-Git-Tag: v4.8.0-rc1~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=07e01beb357a2f1421a27f0fda5a0a13ab9f5ad1;p=thirdparty%2Flibvirt.git

virdbus: Report a debug message that dbus_watch_handle() has failed

Report a debug message if dbus_watch_handle() returns FALSE.
dbus_watch_handle() returns FALSE if there wasn't enough memory for
reading or writing.

Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com>
Reviewed-by: Bjoern Walk <bwalk@linux.ibm.com>
Reviewed-by: Boris Fiuczynski <fiuczy@linux.ibm.com>
Reviewed-by: Stefan Zimmermann <stzi@linux.ibm.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>
---

diff --git a/src/util/virdbus.c b/src/util/virdbus.c
index 49c8b3c1ea..3993bcb860 100644
--- a/src/util/virdbus.c
+++ b/src/util/virdbus.c
@@ -197,7 +197,8 @@ static void virDBusWatchCallback(int fdatch ATTRIBUTE_UNUSED,
     if (events & VIR_EVENT_HANDLE_HANGUP)
         dbus_flags |= DBUS_WATCH_HANGUP;
 
-    (void)dbus_watch_handle(watch, dbus_flags);
+    if (dbus_watch_handle(watch, dbus_flags) == FALSE)
+        VIR_DEBUG("dbus_watch_handle() returned FALSE");
 
     dbus_connection_ref(info->bus);
     while (dbus_connection_dispatch(info->bus) == DBUS_DISPATCH_DATA_REMAINS)