From: Mike Bayer <mike_mp@zzzcomputing.com>
Date: Thu, 28 May 2009 01:00:27 +0000 (+0000)
Subject: fix some tests, a py3k import
X-Git-Tag: rel_0_6_6~203
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=07e3f43642c5c41beed5cd797c3443f7f3ca72cd;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

fix some tests, a py3k import
---

diff --git a/lib/sqlalchemy/dialects/mysql/mysqldb.py b/lib/sqlalchemy/dialects/mysql/mysqldb.py
index fc61391e5a..11c331915c 100644
--- a/lib/sqlalchemy/dialects/mysql/mysqldb.py
+++ b/lib/sqlalchemy/dialects/mysql/mysqldb.py
@@ -101,7 +101,7 @@ class MySQL_mysqldb(MySQLDialect):
         client_flag = opts.get('client_flag', 0)
         if self.dbapi is not None:
             try:
-                import MySQLdb.constants.CLIENT as CLIENT_FLAGS
+                from MySQLdb.constants import CLIENT as CLIENT_FLAGS
                 client_flag |= CLIENT_FLAGS.FOUND_ROWS
             except:
                 pass
diff --git a/test/dialect/oracle.py b/test/dialect/oracle.py
index c55e778a24..c7ec8e65d4 100644
--- a/test/dialect/oracle.py
+++ b/test/dialect/oracle.py
@@ -41,10 +41,10 @@ class CompileTest(TestBase, AssertsCompiledSQL):
         meta  = MetaData()
         parent = Table('parent', meta, Column('id', Integer, primary_key=True), 
            Column('name', String(50)),
-           owner='ed')
+           schema='ed')
         child = Table('child', meta, Column('id', Integer, primary_key=True),
            Column('parent_id', Integer, ForeignKey('ed.parent.id')),
-           owner = 'ed')
+           schema = 'ed')
 
         self.assert_compile(parent.join(child), "ed.parent JOIN ed.child ON ed.parent.id = ed.child.parent_id")
 
diff --git a/test/sql/select.py b/test/sql/select.py
index 3e8733790e..4bee94e142 100644
--- a/test/sql/select.py
+++ b/test/sql/select.py
@@ -1125,10 +1125,10 @@ UNION SELECT mytable.myid FROM mytable"
                 self.assert_compile(stmt, expected_positional_stmt, dialect=sqlite.dialect())
                 nonpositional = stmt.compile()
                 positional = stmt.compile(dialect=sqlite.dialect())
-                pp = positional.get_params()
+                pp = positional.params
                 assert [pp[k] for k in positional.positiontup] == expected_default_params_list
-                assert nonpositional.get_params(**test_param_dict) == expected_test_params_dict, "expected :%s got %s" % (str(expected_test_params_dict), str(nonpositional.get_params(**test_param_dict)))
-                pp = positional.get_params(**test_param_dict)
+                assert nonpositional.construct_params(test_param_dict) == expected_test_params_dict, "expected :%s got %s" % (str(expected_test_params_dict), str(nonpositional.get_params(**test_param_dict)))
+                pp = positional.construct_params(test_param_dict)
                 assert [pp[k] for k in positional.positiontup] == expected_test_params_list
 
         # check that params() doesnt modify original statement
@@ -1147,7 +1147,7 @@ UNION SELECT mytable.myid FROM mytable"
             ":myid_1) AS anon_1 FROM mytable WHERE mytable.myid = (SELECT mytable.myid FROM mytable WHERE mytable.myid = :myid_1)")
         positional = s2.compile(dialect=sqlite.dialect())
 
-        pp = positional.get_params()
+        pp = positional.params
         assert [pp[k] for k in positional.positiontup] == [12, 12]
 
         # check that conflicts with "unique" params are caught
diff --git a/test/sql/testtypes.py b/test/sql/testtypes.py
index cb733172dd..0e6088c429 100644
--- a/test/sql/testtypes.py
+++ b/test/sql/testtypes.py
@@ -683,10 +683,10 @@ class NumericTest(TestBase, AssertsExecutionResults):
         metadata = MetaData(testing.db)
         numeric_table = Table('numeric_table', metadata,
             Column('id', Integer, Sequence('numeric_id_seq', optional=True), primary_key=True),
-            Column('numericcol', Numeric(asdecimal=False)),
-            Column('floatcol', Float),
-            Column('ncasdec', Numeric),
-            Column('fcasdec', Float(asdecimal=True))
+            Column('numericcol', Numeric(precision=10, scale=2, asdecimal=False)),
+            Column('floatcol', Float(precision=10, )),
+            Column('ncasdec', Numeric(precision=10, scale=2)),
+            Column('fcasdec', Float(precision=10, asdecimal=True))
         )
         metadata.create_all()