From: Andrew Jeffery Date: Fri, 5 May 2023 13:19:54 +0000 (+0930) Subject: Revert "ipk: Decode byte data to string in manifest handling" X-Git-Tag: uninative-3.10~143 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=07e5a6331be60d5e35d7336a6215a972ced6eb57;p=thirdparty%2Fopenembedded%2Fopenembedded-core.git Revert "ipk: Decode byte data to string in manifest handling" cf9df9e8d89f ("ipk: Decode byte data to string in manifest handling") did a bit of least-effort fix to a string vs byte sequence issue in the manifest handling. The approach was chosen as it localised the fix, rather than having to analyse further call sites. However since then f2167ae80258 ("package_manager/ipk: do not pipe stderr to stdout") was applied, reworking the output handling from the subcommand. dummy_bytes() now returns a string, so stop trying to decode it. Fixes: f2167ae80258 ("package_manager/ipk: do not pipe stderr to stdout") Cc: Curtis Meier Cc: Pam Eggler (From OE-Core rev: b61739554780d70307d2b6b37d2b3b1c7df93c77) Signed-off-by: Andrew Jeffery Signed-off-by: Alexandre Belloni --- diff --git a/meta/lib/oe/package_manager/ipk/manifest.py b/meta/lib/oe/package_manager/ipk/manifest.py index 469e14c3c6b..3549d7428d7 100644 --- a/meta/lib/oe/package_manager/ipk/manifest.py +++ b/meta/lib/oe/package_manager/ipk/manifest.py @@ -64,7 +64,7 @@ class PkgManifest(Manifest): if len(pkgs_to_install) == 0: return - output = pm.dummy_install(pkgs_to_install).decode('utf-8') + output = pm.dummy_install(pkgs_to_install) with open(self.full_manifest, 'w+') as manifest: pkg_re = re.compile('^Installing ([^ ]+) [^ ].*')