From: Volker Lendecke <vl@samba.org>
Date: Wed, 27 Aug 2025 14:40:54 +0000 (+0200)
Subject: smbd: Simplify samba_private_attr_name()
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=07fa17d08755cae0ca6390352fca9d55aca0c0dd;p=thirdparty%2Fsamba.git

smbd: Simplify samba_private_attr_name()

We have strnequal for this

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/source3/smbd/smb2_trans2.c b/source3/smbd/smb2_trans2.c
index d4ef3bb1c1f..9f60fa3e05b 100644
--- a/source3/smbd/smb2_trans2.c
+++ b/source3/smbd/smb2_trans2.c
@@ -168,16 +168,11 @@ bool samba_private_attr_name(const char *unix_ea_name)
 	prohibited |= strequal(unix_ea_name, SAMBA_XATTR_REPARSE_ATTRIB);
 	prohibited |= strequal(unix_ea_name, XATTR_NTACL_NAME);
 	prohibited |= strequal(unix_ea_name, AFPINFO_EA_NETATALK);
+	prohibited |= strnequal(unix_ea_name,
+				SAMBA_XATTR_DOSSTREAM_PREFIX,
+				strlen(SAMBA_XATTR_DOSSTREAM_PREFIX));
 
-	if (prohibited) {
-		return true;
-	}
-
-	if (strncasecmp_m(unix_ea_name, SAMBA_XATTR_DOSSTREAM_PREFIX,
-			strlen(SAMBA_XATTR_DOSSTREAM_PREFIX)) == 0) {
-		return true;
-	}
-	return false;
+	return prohibited;
 }
 
 /****************************************************************************