From: Daniel Ruf Date: Thu, 29 Mar 2018 21:26:19 +0000 (+0200) Subject: fix: deduplicate the code for the event listeners X-Git-Tag: v6.6.0~3^2~254^2~1 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0804c9002;p=thirdparty%2Ffoundation%2Ffoundation-sites.git fix: deduplicate the code for the event listeners --- diff --git a/js/foundation.slider.js b/js/foundation.slider.js index 67dfeb8d0..d9e67b112 100644 --- a/js/foundation.slider.js +++ b/js/foundation.slider.js @@ -460,20 +460,19 @@ class Slider extends Plugin { curHandle, timer; + const handleChangeEvent = function(e) { + const idx = _this.inputs.index($(this)); + _this._handleEvent(e, _this.handles.eq(idx), $(this).val()); + }; + // IE only triggers the change event when the input loses focus which strictly follows the HTML specification // listen for the enter key and trigger a change // @see https://html.spec.whatwg.org/multipage/input.html#common-input-element-events this.inputs.off('keyup.zf.slider').on('keyup.zf.slider', function (e) { - if(e.keyCode == 13) { - var idx = _this.inputs.index($(this)); - _this._handleEvent(e, _this.handles.eq(idx), $(this).val()); - } + if(e.keyCode == 13) handleChangeEvent.call(this, e); }); - this.inputs.off('change.zf.slider').on('change.zf.slider', function(e) { - var idx = _this.inputs.index($(this)); - _this._handleEvent(e, _this.handles.eq(idx), $(this).val()); - }); + this.inputs.off('change.zf.slider').on('change.zf.slider', handleChangeEvent); if (this.options.clickSelect) { this.$element.off('click.zf.slider').on('click.zf.slider', function(e) {