From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Thu, 12 Sep 2019 22:56:02 +0000 (-0500)
Subject: We don't care if detach fails
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=081ddd52ae2da89474b82b4762aa0becc4426964;p=thirdparty%2Ffreeradius-server.git

We don't care if detach fails
---

diff --git a/src/modules/rlm_python/rlm_python.c b/src/modules/rlm_python/rlm_python.c
index 38698363451..de3a584f6aa 100644
--- a/src/modules/rlm_python/rlm_python.c
+++ b/src/modules/rlm_python/rlm_python.c
@@ -1125,8 +1125,7 @@ static int mod_instantiate(void *instance, CONF_SECTION *conf)
 
 static int mod_detach(void *instance)
 {
-	rlm_python_t *inst = instance;
-	rlm_rcode_t  rcode = RLM_MODULE_OK;
+	rlm_python_t	*inst = instance;
 
 	/*
 	 *      If we don't have a interpreter
@@ -1141,7 +1140,10 @@ static int mod_detach(void *instance)
 	 */
 	PyEval_RestoreThread(inst->interpreter);
 
-	if (inst->detach.function) rcode = do_python_single(inst, NULL, inst->detach.function, "detach");
+	/*
+	 *	We don't care if this fails.
+	 */
+	if (inst->detach.function) (void)do_python_single(inst, NULL, inst->detach.function, "detach");
 
 #define PYTHON_FUNC_DESTROY(_x) python_function_destroy(&inst->_x)
 	PYTHON_FUNC_DESTROY(instantiate);
@@ -1170,7 +1172,7 @@ static int mod_detach(void *instance)
 	if (inst->wide_path) PyMem_RawFree(inst->wide_path);
 #endif
 
-	return rcode;
+	return 0;
 }
 
 static int mod_thread_instantiate(UNUSED CONF_SECTION const *conf, void *instance,