From: Ján Tomko <jtomko@redhat.com>
Date: Thu, 7 May 2015 11:15:06 +0000 (+0200)
Subject: Assign virtio-serial addresses after coldplugging a device
X-Git-Tag: v1.2.16-rc1~87
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=083c33b3243da8ab266c0ff75b6abb217bcbf440;p=thirdparty%2Flibvirt.git

Assign virtio-serial addresses after coldplugging a device

Otherwise we might allow coldplugging a device
that uses an address that is already occupied, creating
an unstartable domain.

https://bugzilla.redhat.com/show_bug.cgi?id=1220195
---

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index f922a2893c..f7433ee9b3 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -8334,6 +8334,8 @@ qemuDomainAttachDeviceConfig(virQEMUCapsPtr qemuCaps,
         dev->data.chr = NULL;
         if (virDomainDefAddImplicitControllers(vmdef) < 0)
             return -1;
+        if (qemuDomainAssignAddresses(vmdef, qemuCaps, NULL) < 0)
+            return -1;
         break;
 
     case VIR_DOMAIN_DEVICE_FS: