From: Pauli <paul.dale@oracle.com>
Date: Thu, 21 May 2020 03:18:42 +0000 (+1000)
Subject: Coverity 1463258: Incorrect expression (EVALUATION_ORDER)
X-Git-Tag: openssl-3.0.0-alpha3~62
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=084b7bec0f615f70c108dfba988ed43d544e00ed;p=thirdparty%2Fopenssl.git

Coverity 1463258: Incorrect expression (EVALUATION_ORDER)

Reviewed-by: Kurt Roeckx <kurt@roeckx.be>
(Merged from https://github.com/openssl/openssl/pull/11892)
---

diff --git a/crypto/x509/v3_ncons.c b/crypto/x509/v3_ncons.c
index d7b82b775e9..4543ec2e110 100644
--- a/crypto/x509/v3_ncons.c
+++ b/crypto/x509/v3_ncons.c
@@ -197,7 +197,7 @@ static int print_nc_ipadd(BIO *bp, ASN1_OCTET_STRING *ip)
     int len2 = ip->length - len1;
     char *ip1 = ipaddr_to_asc(ip->data, len1);
     char *ip2 = ipaddr_to_asc(ip->data + len1, len2);
-    int ret = ret = ip1 != NULL && ip2 != NULL
+    int ret = ip1 != NULL && ip2 != NULL
         && BIO_printf(bp, "IP:%s/%s", ip1, ip2) > 0;
 
     OPENSSL_free(ip1);