From: Simon Green Date: Fri, 8 Nov 2013 00:40:40 +0000 (+1000) Subject: Bug 916633 - join_activity_entries doesn't reconstitute text with commas correctly. X-Git-Tag: bugzilla-4.5.2~91 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=08680add732f86b4bd13ac9d0ddaf719b09bd5f9;p=thirdparty%2Fbugzilla.git Bug 916633 - join_activity_entries doesn't reconstitute text with commas correctly. r=glob, a=sgreen --- diff --git a/Bugzilla/Util.pm b/Bugzilla/Util.pm index a9ff86c8b7..bda0e0c903 100644 --- a/Bugzilla/Util.pm +++ b/Bugzilla/Util.pm @@ -496,8 +496,9 @@ sub join_activity_entries { return $current_change . $new_change; } - # All other fields get a space - if (substr($new_change, 0, 1) eq ' ') { + # All other fields get a space unless the first character of the second + # string is a comma or space + if (substr($new_change, 0, 1) eq ',' || substr($new_change, 0, 1) eq ' ') { return $current_change . $new_change; } else { return $current_change . ' ' . $new_change;