From: Amos Jeffries <squid3@treenet.co.nz>
Date: Mon, 20 Apr 2009 08:48:00 +0000 (+1200)
Subject: Bug 2625: Ident: bad read from external lookup buffer
X-Git-Tag: SQUID_3_0_STABLE15~19
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0869ba71c8482e3110a781e87a41c64b7582887d;p=thirdparty%2Fsquid.git

Bug 2625: Ident: bad read from external lookup buffer

with thanks to Michael <michael.dotzler@leoni.com> for tracking it down.
---

diff --git a/src/redirect.cc b/src/redirect.cc
index f9142a303e..183f71551a 100644
--- a/src/redirect.cc
+++ b/src/redirect.cc
@@ -137,7 +137,7 @@ redirectStart(ClientHttpRequest * http, RH * handler, void *data)
 
     if (http->request->auth_user_request)
         r->client_ident = http->request->auth_user_request->username();
-    else if (http->request->extacl_user.buf() != NULL) {
+    else if (http->request->extacl_user.size()) {
         r->client_ident = http->request->extacl_user.buf();
     }