From: Oliver Kurth <okurth@vmware.com>
Date: Tue, 27 Aug 2019 19:55:36 +0000 (-0700)
Subject: Do not treat AsyncSocketState as a boolean
X-Git-Tag: stable-11.1.0~263
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=08722696a8d774e3603bda9e7933d31675469179;p=thirdparty%2Fopen-vm-tools.git

Do not treat AsyncSocketState as a boolean

AsyncSocketState is an enum.  Storing it into boolean
results in unexpected and undefined behavior.
---

diff --git a/open-vm-tools/lib/asyncsocket/asyncsocket.c b/open-vm-tools/lib/asyncsocket/asyncsocket.c
index bc75203c4..6e6fff0c1 100644
--- a/open-vm-tools/lib/asyncsocket/asyncsocket.c
+++ b/open-vm-tools/lib/asyncsocket/asyncsocket.c
@@ -512,7 +512,7 @@ AsyncTCPSocketPollParams(AsyncTCPSocket *asock)
    return AsyncSocketGetPollParams(BaseSocket(asock));
 }
 
-static INLINE Bool
+static INLINE AsyncSocketState
 AsyncTCPSocketGetState(AsyncTCPSocket *asock)
 {
    return AsyncSocketGetState(BaseSocket(asock));