From: Evert Timberg Date: Sat, 30 May 2020 20:42:23 +0000 (-0400) Subject: Radar charts should fill to the center by default (#7446) X-Git-Tag: v3.0.0-beta.2~114 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=08854a424121f860700b94cf7b6ae952b3fdb0f0;p=thirdparty%2FChart.js.git Radar charts should fill to the center by default (#7446) * Radar charts should fill to the center by default * Update tests for new defaults --- diff --git a/src/controllers/controller.radar.js b/src/controllers/controller.radar.js index a84d3bc31..b596f725a 100644 --- a/src/controllers/controller.radar.js +++ b/src/controllers/controller.radar.js @@ -13,6 +13,7 @@ defaults.set('radar', { }, elements: { line: { + fill: 'start', tension: 0 // no bezier in radar } } diff --git a/test/fixtures/controller.radar/backgroundColor/scriptable.js b/test/fixtures/controller.radar/backgroundColor/scriptable.js index ee32bcf42..0f5d313dd 100644 --- a/test/fixtures/controller.radar/backgroundColor/scriptable.js +++ b/test/fixtures/controller.radar/backgroundColor/scriptable.js @@ -30,7 +30,8 @@ module.exports = { return index === 0 ? '#ff0000' : index === 1 ? '#00ff00' : '#ff00ff'; - } + }, + fill: true, }, point: { backgroundColor: '#0000ff', diff --git a/test/fixtures/controller.radar/backgroundColor/value.js b/test/fixtures/controller.radar/backgroundColor/value.js index 0decaa6c0..1c8651edb 100644 --- a/test/fixtures/controller.radar/backgroundColor/value.js +++ b/test/fixtures/controller.radar/backgroundColor/value.js @@ -20,7 +20,8 @@ module.exports = { title: false, elements: { line: { - backgroundColor: '#00ff00' + backgroundColor: '#00ff00', + fill: true, }, point: { radius: 10 diff --git a/test/fixtures/controller.radar/borderDash/scriptable.js b/test/fixtures/controller.radar/borderDash/scriptable.js index 0feed22cc..8415eff43 100644 --- a/test/fixtures/controller.radar/borderDash/scriptable.js +++ b/test/fixtures/controller.radar/borderDash/scriptable.js @@ -25,7 +25,8 @@ module.exports = { borderColor: '#00ff00', borderDash: function(ctx) { return ctx.datasetIndex === 0 ? [5] : [10]; - } + }, + fill: true, }, point: { radius: 10