From: Nick Alcock <nick.alcock@oracle.com>
Date: Mon, 15 Jul 2024 18:59:13 +0000 (+0100)
Subject: libctf: improve ECTF_NOPARENT error message
X-Git-Tag: binutils-2_43~18
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=08b94b31091908019e3e3952a256c64540add25d;p=thirdparty%2Fbinutils-gdb.git

libctf: improve ECTF_NOPARENT error message

This erorr doesn't just indicate that there is no parent dictionary
(that's routine, and true of all dicts that are parents themselves)
but that a parent is *needed* but wasn't found.

include/
	* ctf-api.h (_CTF_ERRORS) [ECTF_NOPARENT]: Improve error message.

ld/
	* testsuite/ld-ctf/diag-parname.d: Adjust.
---

diff --git a/include/ctf-api.h b/include/ctf-api.h
index f1087bc0542..ad5add23706 100644
--- a/include/ctf-api.h
+++ b/include/ctf-api.h
@@ -196,7 +196,7 @@ typedef struct ctf_snapshot_id
   _CTF_ITEM (ECTF_NOCTFDATA, "File does not contain CTF data.") \
   _CTF_ITEM (ECTF_NOCTFBUF, "Buffer does not contain CTF data.") \
   _CTF_ITEM (ECTF_NOSYMTAB, "Symbol table information is not available.") \
-  _CTF_ITEM (ECTF_NOPARENT, "The parent CTF dictionary is unavailable.") \
+  _CTF_ITEM (ECTF_NOPARENT, "The parent CTF dictionary is needed but unavailable.") \
   _CTF_ITEM (ECTF_DMODEL, "Data model mismatch.") \
   _CTF_ITEM (ECTF_LINKADDEDLATE, "File added to link too late.") \
   _CTF_ITEM (ECTF_ZALLOC, "Failed to allocate (de)compression buffer.") \
diff --git a/ld/testsuite/ld-ctf/diag-parname.d b/ld/testsuite/ld-ctf/diag-parname.d
index f8fcd683a9d..4672f71ae9b 100644
--- a/ld/testsuite/ld-ctf/diag-parname.d
+++ b/ld/testsuite/ld-ctf/diag-parname.d
@@ -2,4 +2,4 @@
 #source: diag-parname.s
 #ld: -shared --ctf-variables
 #name: Diagnostics - No parent dictionary
-#warning: CTF linking failed; output will have no CTF section: The parent CTF dictionary is unavailable
+#warning: CTF linking failed; output will have no CTF section: The parent CTF dictionary is needed but unavailable