From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Wed, 16 Jul 2025 15:55:44 +0000 (+0200)
Subject: dnsdist: Apply Otto's suggestion
X-Git-Tag: rec-5.4.0-alpha0~19^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=08d790466b2e465700f193b503ff0a76a3a0680e;p=thirdparty%2Fpdns.git

dnsdist: Apply Otto's suggestion

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
---

diff --git a/pdns/dnsdistdist/dnsdist-configuration-yaml.cc b/pdns/dnsdistdist/dnsdist-configuration-yaml.cc
index a78f295ab6..1d0f534b43 100644
--- a/pdns/dnsdistdist/dnsdist-configuration-yaml.cc
+++ b/pdns/dnsdistdist/dnsdist-configuration-yaml.cc
@@ -1785,9 +1785,8 @@ void registerKVSObjects([[maybe_unused]] const KeyValueStoresConfiguration& conf
 void registerNMGObjects(const ::rust::Vec<NetmaskGroupConfiguration>& nmgs)
 {
   for (const auto& netmaskGroup : nmgs) {
-    std::shared_ptr<NetmaskGroup> nmg;
     bool registered = true;
-    nmg = dnsdist::configuration::yaml::getRegisteredTypeByName<NetmaskGroup>(std::string(netmaskGroup.name));
+    auto nmg = dnsdist::configuration::yaml::getRegisteredTypeByName<NetmaskGroup>(std::string(netmaskGroup.name));
     if (!nmg) {
       nmg = std::make_shared<NetmaskGroup>();
       registered = false;