From: Ralf Habacker <ralf.habacker@freenet.de>
Date: Wed, 22 Apr 2015 12:47:08 +0000 (+0200)
Subject: dbus_server_set_auth_mechanisms: Fix returning without unlocking server->mutex->lock... 
X-Git-Tag: dbus-1.8.18~10
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=08e2b810622096e84e9c9099450bfadf5768e97e;p=thirdparty%2Fdbus.git

dbus_server_set_auth_mechanisms: Fix returning without unlocking server->mutex->lock (CID 54749).

Reported by Coverity: CID 54749: Missing unlock (LOCK)

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=90021
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
---

diff --git a/dbus/dbus-server.c b/dbus/dbus-server.c
index c1d5f6e58..7b8107922 100644
--- a/dbus/dbus-server.c
+++ b/dbus/dbus-server.c
@@ -1043,7 +1043,10 @@ dbus_server_set_auth_mechanisms (DBusServer  *server,
     {
       copy = _dbus_dup_string_array (mechanisms);
       if (copy == NULL)
-        return FALSE;
+        {
+          SERVER_UNLOCK (server);
+          return FALSE;
+        }
     }
   else
     copy = NULL;