From: Hongwei Bi <hwbi2008@gmail.com>
Date: Tue, 17 Sep 2013 06:21:32 +0000 (+0800)
Subject: virsh: Fix a wrong check in cmdEcho()
X-Git-Tag: CVE-2013-4311~40
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0925ad4e282125fb7e94f2dffc731cf3f1b3eacc;p=thirdparty%2Flibvirt.git

virsh: Fix a wrong check in cmdEcho()

What should be checked here is xmlbuf rather than buf.
---

diff --git a/tools/virsh.c b/tools/virsh.c
index bf2fbf81c7..ac354acda5 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -921,7 +921,7 @@ cmdEcho(vshControl *ctl, const vshCmd *cmd)
 
         if (xml) {
             virBufferEscapeString(&xmlbuf, "%s", arg);
-            if (virBufferError(&buf)) {
+            if (virBufferError(&xmlbuf)) {
                 vshPrint(ctl, "%s", _("Failed to allocate XML buffer"));
                 return false;
             }