From: Paul Eggert <eggert@cs.ucla.edu>
Date: Fri, 22 Sep 2023 02:09:15 +0000 (-0700)
Subject: maint: use mbszero
X-Git-Tag: v9.5~153
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=092f8178c00fb9c3b2aaf21c5380a529d503afb8;p=thirdparty%2Fcoreutils.git

maint: use mbszero

* bootstrap.conf (gnulib_modules): Add mbszero.
* src/df.c (replace_invalid_chars):
* src/ls.c (quote_name_buf):
* src/pathchk.c (portable_chars_only):
* src/printf.c (STRTOX):
* src/wc.c (wc):
Prefer mbszero to clearing an mbstate_t by hand.
---

diff --git a/bootstrap.conf b/bootstrap.conf
index a15bda3417..0b1ed95f63 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -165,6 +165,7 @@ gnulib_modules="
   mbschr
   mbslen
   mbswidth
+  mbszero
   mcel-prefer
   memcasecmp
   memchr
diff --git a/src/df.c b/src/df.c
index c5eb820517..1f3665a4af 100644
--- a/src/df.c
+++ b/src/df.c
@@ -319,7 +319,7 @@ replace_invalid_chars (char *cell)
 {
   char *srcend = cell + strlen (cell);
   char *dst = cell;
-  mbstate_t mbstate = {0};
+  mbstate_t mbstate; mbszero (&mbstate);
   size_t n;
 
   for (char *src = cell; src != srcend; src += n)
diff --git a/src/ls.c b/src/ls.c
index dfb7718f74..eb74f16785 100644
--- a/src/ls.c
+++ b/src/ls.c
@@ -4609,7 +4609,7 @@ quote_name_buf (char **inbuf, size_t bufsize, char *name,
                      reach its end, replacing each non-printable multibyte
                      character with a single question mark.  */
                   {
-                    mbstate_t mbstate = {0};
+                    mbstate_t mbstate; mbszero (&mbstate);
                     do
                       {
                         wchar_t wc;
diff --git a/src/pathchk.c b/src/pathchk.c
index 74ff1fa098..0e89914059 100644
--- a/src/pathchk.c
+++ b/src/pathchk.c
@@ -188,7 +188,7 @@ portable_chars_only (char const *file, size_t filelen)
 
   if (*invalid)
     {
-      mbstate_t mbstate = {0};
+      mbstate_t mbstate; mbszero (&mbstate);
       size_t charlen = mbrlen (invalid, filelen - validlen, &mbstate);
       error (0, 0,
              _("non-portable character %s in file name %s"),
diff --git a/src/printf.c b/src/printf.c
index a6f63cb005..16ea1c17f1 100644
--- a/src/printf.c
+++ b/src/printf.c
@@ -172,7 +172,7 @@ FUNC_NAME (char const *s)						 \
                                                                          \
       if (MB_CUR_MAX > 1 && *(s + 1))					 \
         {								 \
-          mbstate_t mbstate = {0};					 \
+          mbstate_t mbstate; mbszero (&mbstate);			 \
           wchar_t wc;							 \
           size_t slen = strlen (s);					 \
           ssize_t bytes;						 \
diff --git a/src/wc.c b/src/wc.c
index 130be8c32c..1753acfc16 100644
--- a/src/wc.c
+++ b/src/wc.c
@@ -452,7 +452,7 @@ wc (int fd, char const *file_x, struct fstatus *fstatus, off_t current_pos)
     {
       bool in_word = false;
       uintmax_t linepos = 0;
-      mbstate_t state = {0};
+      mbstate_t state; mbszero (&state);
       bool in_shift = false;
 # if SUPPORT_OLD_MBRTOWC
       /* Back-up the state before each multibyte character conversion and