From: Frédéric Buclin <LpSolit@gmail.com>
Date: Fri, 14 Feb 2014 23:27:26 +0000 (+0100)
Subject: Bug 966676: The 'sudo' cookie should not be accessible from JavaScript
X-Git-Tag: bugzilla-4.5.3~72
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=09317bf98d6100f3242150c6bd683c58d5e9793e;p=thirdparty%2Fbugzilla.git

Bug 966676: The 'sudo' cookie should not be accessible from JavaScript
r=dkl a=justdave
---

diff --git a/relogin.cgi b/relogin.cgi
index e2effd1058..52944a8111 100755
--- a/relogin.cgi
+++ b/relogin.cgi
@@ -137,11 +137,18 @@ elsif ($action eq 'begin-sudo') {
 
     # For future sessions, store the unique ID of the target user
     my $token = Bugzilla::Token::_create_token($user->id, 'sudo', $target_user->id);
+
+    my %args;
+    if (Bugzilla->params->{ssl_redirect}) {
+        $args{'-secure'} = 1;
+    }
+
     $cgi->send_cookie('-name'    => 'sudo',
                       '-expires' => $time_string,
-                      '-value'   => $token
-    );
-    
+                      '-value'   => $token,
+                      '-httponly' => 1,
+                      %args);
+
     # For the present, change the values of Bugzilla::user & Bugzilla::sudoer
     Bugzilla->sudo_request($target_user, $user);