From: Jakub Kicinski Date: Tue, 5 Nov 2019 21:13:36 +0000 (-0800) Subject: devlink: require resource parameters X-Git-Tag: v5.4.0~14 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0932814458eb386644c1248e5aabf8303c38d7bb;p=thirdparty%2Fiproute2.git devlink: require resource parameters If devlink resource set parameters are not provided it crashes: $ devlink resource set netdevsim/netdevsim0 Segmentation fault (core dumped) This is because even though DL_OPT_RESOURCE_PATH and DL_OPT_RESOURCE_SIZE are passed as o_required, the validation table doesn't contain a relevant string. Fixes: 8cd644095842 ("devlink: Add support for devlink resource abstraction") Signed-off-by: Jakub Kicinski Acked-by: Jiri Pirko Signed-off-by: Stephen Hemminger --- diff --git a/devlink/devlink.c b/devlink/devlink.c index 5bbe0bddd..056ac95ee 100644 --- a/devlink/devlink.c +++ b/devlink/devlink.c @@ -1121,6 +1121,8 @@ static const struct dl_args_metadata dl_args_required[] = { {DL_OPT_DPIPE_TABLE_NAME, "Dpipe table name expected."}, {DL_OPT_DPIPE_TABLE_COUNTERS, "Dpipe table counter state expected."}, {DL_OPT_ESWITCH_ENCAP_MODE, "E-Switch encapsulation option expected."}, + {DL_OPT_RESOURCE_PATH, "Resource path expected."}, + {DL_OPT_RESOURCE_SIZE, "Resource size expected."}, {DL_OPT_PARAM_NAME, "Parameter name expected."}, {DL_OPT_PARAM_VALUE, "Value to set expected."}, {DL_OPT_PARAM_CMODE, "Configuration mode expected."},