From: Daniel Kiper Date: Thu, 10 Mar 2022 15:40:43 +0000 (+0100) Subject: loader/i386/bsd: Initialize ptr variable in grub_bsd_add_meta() X-Git-Tag: grub-2.12-rc1~444 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=093ac51dc6c022bbb7402ba8b632ee68325944d3;p=thirdparty%2Fgrub.git loader/i386/bsd: Initialize ptr variable in grub_bsd_add_meta() Latest GCC may complain in that way: In file included from ../include/grub/disk.h:31, from ../include/grub/file.h:26, from ../include/grub/loader.h:23, from loader/i386/bsd.c:19: loader/i386/bsd.c: In function ‘grub_cmd_openbsd’: ../include/grub/misc.h:71:10: error: ‘ptr’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 71 | return grub_memmove (dest, src, n); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ loader/i386/bsd.c:266:9: note: ‘ptr’ was declared here 266 | void *ptr; | ^~~ So, let's fix it by assigning NULL to ptr in grub_bsd_add_meta(). Signed-off-by: Daniel Kiper Reviewed-by: Robbie Harwood --- diff --git a/grub-core/loader/i386/bsd.c b/grub-core/loader/i386/bsd.c index 6c324ca30..799a24cd2 100644 --- a/grub-core/loader/i386/bsd.c +++ b/grub-core/loader/i386/bsd.c @@ -263,7 +263,7 @@ grub_err_t grub_bsd_add_meta (grub_uint32_t type, const void *data, grub_uint32_t len) { grub_err_t err; - void *ptr; + void *ptr = NULL; err = grub_bsd_add_meta_ptr (type, &ptr, len); if (err)