From: Ján Tomko <jtomko@redhat.com>
Date: Tue, 23 Nov 2021 13:51:18 +0000 (+0100)
Subject: ch: fix logic in virCHMonitorBuildPtyJson
X-Git-Tag: v7.10.0-rc1~34
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=096412f1ba5480879539e17e65f6c6c66f493e85;p=thirdparty%2Flibvirt.git

ch: fix logic in virCHMonitorBuildPtyJson

There is a leftover 'ptys' variable, which we only assign
to and one assignment to 'content', where we add an empty
'pty' object.

Remove 'ptys'.

Fixes: 93accefd9eca1bc3d7e923a979ab2d1b8a312ff7
Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Kristína Hanicová <khanicov@redhat.com>
---

diff --git a/src/ch/ch_monitor.c b/src/ch/ch_monitor.c
index 691d1ce64b..12c10da874 100644
--- a/src/ch/ch_monitor.c
+++ b/src/ch/ch_monitor.c
@@ -88,8 +88,6 @@ virCHMonitorBuildCPUJson(virJSONValue *content, virDomainDef *vmdef)
 static int
 virCHMonitorBuildPTYJson(virJSONValue *content, virDomainDef *vmdef)
 {
-    virJSONValue *ptys = virJSONValueNewObject();
-
     if (vmdef->nconsoles) {
         g_autoptr(virJSONValue) pty = virJSONValueNewObject();
         if (virJSONValueObjectAppendString(pty, "mode", "Pty") < 0)
@@ -100,7 +98,7 @@ virCHMonitorBuildPTYJson(virJSONValue *content, virDomainDef *vmdef)
 
     if (vmdef->nserials) {
         g_autoptr(virJSONValue) pty = virJSONValueNewObject();
-        if (virJSONValueObjectAppendString(ptys, "mode", "Pty") < 0)
+        if (virJSONValueObjectAppendString(pty, "mode", "Pty") < 0)
             return -1;
         if (virJSONValueObjectAppend(content, "serial", &pty) < 0)
             return -1;