From: Uros Bizjak <ubizjak@gmail.com>
Date: Sun, 16 Feb 2025 21:01:27 +0000 (+0100)
Subject: middle-end: Fixup constant integers when expanding __builtin_crc [PR118288]
X-Git-Tag: basepoints/gcc-16~1960
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=09684c53bca7dad47d36875b359e83551f9015fd;p=thirdparty%2Fgcc.git

middle-end: Fixup constant integers when expanding __builtin_crc [PR118288]

Constant integers with MSB set have to be represented as corresponding
signed integers.  Use gen_int_mode to emit them in the correct way.

	PR middle-end/118288

gcc/ChangeLog:

	* builtins.cc (expand_builtin_crc_table_based):
	Use gen_int_mode to emit constant integers with MSB set.

gcc/testsuite/ChangeLog:

	* gcc.dg/pr118288.c: New test.
---

diff --git a/gcc/builtins.cc b/gcc/builtins.cc
index 468bd65bc42..c8841032f03 100644
--- a/gcc/builtins.cc
+++ b/gcc/builtins.cc
@@ -7803,6 +7803,9 @@ expand_builtin_crc_table_based (internal_fn fn, scalar_mode crc_mode,
   gcc_assert (TREE_CODE (rhs3) == INTEGER_CST);
   rtx op3 = gen_int_mode (TREE_INT_CST_LOW (rhs3), crc_mode);
 
+  if (CONST_INT_P (op2))
+    op2 = gen_int_mode (INTVAL (op2), crc_mode);
+
   if (fn == IFN_CRC)
     expand_crc_table_based (target, op1, op2, op3, data_mode);
   else
diff --git a/gcc/testsuite/gcc.dg/pr118288.c b/gcc/testsuite/gcc.dg/pr118288.c
new file mode 100644
index 00000000000..8cc981d065d
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr118288.c
@@ -0,0 +1,8 @@
+/* PR middle-end 118288 */
+/* { dg-do compile }  */
+/* { dg-options "-O2" } */
+
+signed char crc8_data8 ()
+{
+  return __builtin_crc8_data8 ('a', 0xff, 0x12);
+}