From: Fred Morcos Date: Mon, 8 May 2023 12:24:39 +0000 (+0200) Subject: Quote the output vars X-Git-Tag: rec-4.9.0-beta1~29^2~5 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=098bfe746aaefd6eca6a05fe72ba77a5441f3e9b;p=thirdparty%2Fpdns.git Quote the output vars --- diff --git a/.github/workflows/build-and-test-all.yml b/.github/workflows/build-and-test-all.yml index 4946006ca2..3a70f76d6a 100644 --- a/.github/workflows/build-and-test-all.yml +++ b/.github/workflows/build-and-test-all.yml @@ -22,7 +22,7 @@ jobs: UBSAN_OPTIONS: "print_stacktrace=1:halt_on_error=1:suppressions=${{ github.workspace }}/build-scripts/UBSan.supp" UNIT_TESTS: yes outputs: - clang-tidy-auth-failed: ${{ steps.clang-tidy-annotations.outputs.failed }} + clang-tidy-failed: ${{steps.clang-tidy-annotations.outputs.failed}} steps: - uses: PowerDNS/pdns/set-ubuntu-mirror@meta - uses: actions/checkout@v3 @@ -95,7 +95,7 @@ jobs: run: working-directory: ./pdns/recursordist/ outputs: - clang-tidy-recursor-failed: ${{ steps.clang-tidy-annotations.outputs.failed }} + clang-tidy-failed: ${{ steps.clang-tidy-annotations.outputs.failed }} steps: - uses: PowerDNS/pdns/set-ubuntu-mirror@meta - uses: actions/checkout@v3 @@ -169,7 +169,7 @@ jobs: run: working-directory: ./pdns/dnsdistdist/ outputs: - clang-tidy-dnsdist-failed: ${{ steps.clang-tidy-annotations.outputs.failed }} + clang-tidy-failed: ${{ steps.clang-tidy-annotations.outputs.failed }} steps: - uses: PowerDNS/pdns/set-ubuntu-mirror@meta - uses: actions/checkout@v3 @@ -537,10 +537,10 @@ jobs: runs-on: ubuntu-20.04 name: Check whether clang-tidy succeeded steps: - - run: | - if [ ${{ needs.build-auth.outputs.clang-tidy-auth-failed }} != 0 -o ${{ needs.build-dnsdist.outputs.clang-tidy-dnsdist-failed }} != 0 -o ${{ needs.build-recursor.outputs.clang-tidy-recursor-failed }} != 0 ]; then - exit 1 - fi + - run: | + if [ "${{needs.build-auth.outputs.clang-tidy-failed}}" != "0" -o "${{needs.build-dnsdist.outputs.clang-tidy-failed}}" != "0" -o "${{needs.build-recursor.outputs.clang-tidy-failed}}" != "0" ]; then + exit 1 + fi collect: needs: