From: Stathis Voukelatos Date: Mon, 9 Jan 2012 13:27:13 +0000 (+0100) Subject: BUG/MINOR: fix typo in processing of http-send-name-header X-Git-Tag: v1.5-dev8~41 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=09a030a9a43380ff1dc6a6b1c59e86bed2dc8f48;p=thirdparty%2Fhaproxy.git BUG/MINOR: fix typo in processing of http-send-name-header I downloaded version 1.4.19 this morning. While merging the code changes to a custom build that we have here for our project I noticed a typo in 'session.c', in the new code for inserting the server name in the HTTP header. The fix that I did is shown in the patch below. [WT: the bug is harmless, it is only suboptimal] --- diff --git a/src/session.c b/src/session.c index d87813e371..e5b76eb3a2 100644 --- a/src/session.c +++ b/src/session.c @@ -1888,7 +1888,7 @@ struct task *process_session(struct task *t) /* Now we can add the server name to a header (if requested) */ /* check for HTTP mode and proxy server_name_hdr_name != NULL */ - if ((s->flags && SN_BE_ASSIGNED) && + if ((s->flags & SN_BE_ASSIGNED) && (s->be->mode == PR_MODE_HTTP) && (s->be->server_id_hdr_name != NULL)) {