From: Otto <otto.moerbeek@open-xchange.com>
Date: Mon, 22 Nov 2021 13:09:55 +0000 (+0100)
Subject: Fix logic botch introduced by notify handing
X-Git-Tag: dnsdist-1.7.0-beta2~12^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=09a22e8c919b2ed55d98723fb14a33948aa6f517;p=thirdparty%2Fpdns.git

Fix logic botch introduced by notify handing

See #10751, some extra scrutiny review is needed to make sure no
other similat issue remains.
---

diff --git a/pdns/pdns_recursor.cc b/pdns/pdns_recursor.cc
index a321382896..334e4b491c 100644
--- a/pdns/pdns_recursor.cc
+++ b/pdns/pdns_recursor.cc
@@ -2997,6 +2997,7 @@ static void handleRunningTCPQuestion(int fd, FDMultiplexer::funcparam_t& var)
             if (dc->d_eventTrace.enabled() && SyncRes::s_event_trace_enabled & SyncRes::event_trace_to_log) {
               g_log << Logger::Info << dc->d_eventTrace.toString() << endl;
             }
+            return;
           } // cache hit
         } // query opcode