From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Thu, 10 Aug 2023 03:11:51 +0000 (+1200)
Subject: s4:kdc: Fix leak of sdb_entry
X-Git-Tag: tevent-0.16.0~1007
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=09e13845aecb6b7e6e23a2ea4c8fccb8fe2a86f6;p=thirdparty%2Fsamba.git

s4:kdc: Fix leak of sdb_entry

We should take the common ‘out’ path to ensure that we call
sdb_entry_free() on the entry.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source4/kdc/db-glue.c b/source4/kdc/db-glue.c
index e6aadaf3539..37f9734fa91 100644
--- a/source4/kdc/db-glue.c
+++ b/source4/kdc/db-glue.c
@@ -1680,7 +1680,8 @@ static krb5_error_code samba_kdc_message2entry(krb5_context context,
 					     kdc_db_ctx->msg_ctx,
 					     kdc_db_ctx->ev_ctx,
 					     msg->dn);
-		return SDB_ERR_NOT_FOUND_HERE;
+		ret = SDB_ERR_NOT_FOUND_HERE;
+		goto out;
 	} else {
 		/*
 		 * oh, no password.  Apparently (comment in