From: Stefan Metzmacher Date: Wed, 26 Feb 2020 13:16:05 +0000 (+0100) Subject: lib/async_req: remove useless "reentrant" support from async_connect_send() X-Git-Tag: ldb-2.2.0~1582 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=09ea7248e017eddd4764a2b643b720b73c6ec21b;p=thirdparty%2Fsamba.git lib/async_req: remove useless "reentrant" support from async_connect_send() Now that open_socket_out*() doesn't do the strange reentrant calls, we can remove support for this in async_connect_send(), so that we'll never get any new users of this. Signed-off-by: Stefan Metzmacher Reviewed-by: Jeremy Allison --- diff --git a/lib/async_req/async_sock.c b/lib/async_req/async_sock.c index d0cb06b0638..e436d00ac79 100644 --- a/lib/async_req/async_sock.c +++ b/lib/async_req/async_sock.c @@ -131,10 +131,6 @@ struct tevent_req *async_connect_send( * The only errno indicating that an initial connect is still * in flight is EINPROGRESS. * - * We get EALREADY when someone calls us a second time for a - * given fd and the connect is still in flight (and returned - * EINPROGRESS the first time). - * * This allows callers like open_socket_out_send() to reuse * fds and call us with an fd for which the connect is still * in flight. The proper thing to do for callers would be @@ -142,7 +138,7 @@ struct tevent_req *async_connect_send( * socket. */ - if (errno != EINPROGRESS && errno != EALREADY) { + if (errno != EINPROGRESS) { tevent_req_error(req, errno); return tevent_req_post(req, ev); }