From: Willem Toorop <willem@nlnetlabs.nl>
Date: Wed, 13 Jul 2022 21:36:06 +0000 (+0200)
Subject: Fix #46: Print network errors when secure tracing
X-Git-Tag: 1.8.2-rc.1~5
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=09ebd88d1fbc46f49d45fa0ea527f534925ab091;p=thirdparty%2Fldns.git

Fix #46: Print network errors when secure tracing
---

diff --git a/Changelog b/Changelog
index 601a2ecf..23651c50 100644
--- a/Changelog
+++ b/Changelog
@@ -11,6 +11,8 @@
 	* bugfix #166: Grow buffer when writing chars and fixed size
 	  strings when converting to presentation format, preventing
 	  potential assersion errors.
+	* bugfix #46: Print failed to get packet instead of null when
+	  secure tracing with drill. Thanks reedjc
 
 1.8.1	2021-12-03
 	* bugfix #146: ldns-1.7.1 had soname 3.0, so ldns-1.8.x soname
diff --git a/drill/dnssec.c b/drill/dnssec.c
index d4170492..687cfe55 100644
--- a/drill/dnssec.c
+++ b/drill/dnssec.c
@@ -180,7 +180,20 @@ ldns_verify_denial(ldns_pkt *pkt, ldns_rdf *name, ldns_rr_type type, ldns_rr_lis
 
 	ldns_rr_list *nsecs;
 	ldns_status result;
-	
+	const ldns_rr_descriptor *descriptor;
+
+	if (!pkt) {
+		descriptor = ldns_rr_descript(type);
+
+		printf("NETWORk ERROR! Cannot verify denial for: ");
+		ldns_rdf_print(stdout, name);
+		printf(" type ");
+		if (descriptor && descriptor->_name)
+			printf("%s", descriptor->_name);
+		else
+			printf("TYPE%u", type);
+		return LDNS_STATUS_CRYPTO_NO_RRSIG;
+	}
 	if (verbosity >= 5) {
 		printf("VERIFY DENIAL FROM:\n");
 		ldns_pkt_print(stdout, pkt);