From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Sat, 28 Jan 2017 13:33:11 +0000 (+0000)
Subject: Doxygen and other minor fixes
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0a0f2bfec2cb8ea417228dbe1ddcad08dd37257b;p=thirdparty%2Ffreeradius-server.git

Doxygen and other minor fixes
---

diff --git a/src/lib/dict.c b/src/lib/dict.c
index d16526cef1b..edff684d23d 100644
--- a/src/lib/dict.c
+++ b/src/lib/dict.c
@@ -3072,7 +3072,7 @@ fr_dict_attr_t *fr_dict_unknown_afrom_fields(TALLOC_CTX *ctx, fr_dict_attr_t con
 
 	if (!fr_cond_assert(parent)) {
 		fr_strerror_printf("%s: Invalid argument - parent was NULL", __FUNCTION__);
-		return -1;
+		return NULL;
 	}
 
 	/*
@@ -3192,9 +3192,6 @@ int fr_dict_unknown_vendor_afrom_num(TALLOC_CTX *ctx, fr_dict_attr_t **out,
 				   "attributes, not '%s'", fr_int2str(dict_attr_types, parent->type, "?Unknown?"));
 		return -1;
 	}
-
-
-	return 0;
 }
 
 /** Initialise a fr_dict_attr_t from an ASCII attribute and value
@@ -3395,7 +3392,7 @@ ssize_t fr_dict_unknown_afrom_oid_str(TALLOC_CTX *ctx, fr_dict_attr_t **out,
  * Find the first invalid attribute name char in the string pointed to by name.
  *
  * Copy the characters between the start of the name string and the first none
- * #dict_attr_allowed_char to a buffer and initialise da as an unknown attribute.
+ * #dict_attr_allowed_chars char to a buffer and initialise da as an unknown attribute.
  *
  * @param[in] ctx	To allocate unknown #fr_dict_attr_t in.
  * @param[out] out	Where to write the head of the chain unknown dictionary attributes.
@@ -3915,11 +3912,11 @@ fr_dict_attr_t const *fr_dict_vendor_attr_by_num(fr_dict_t *dict, unsigned int v
  * to by name.
  *
  * Copy the characters between the start of the name string and the first
- * none dict_attr_allowed_char to a buffer and perform a dictionary lookup
+ * none #dict_attr_allowed_chars char to a buffer and perform a dictionary lookup
  * using that value.
  *
  * If the attribute exists, advance the pointer pointed to by name
- * to the first none dict_attr_allowed_char char, and return the DA.
+ * to the first none #dict_attr_allowed_chars char, and return the DA.
  *
  * If the attribute does not exist, don't advance the pointer and return
  * NULL.
diff --git a/src/main/tmpl.c b/src/main/tmpl.c
index e2fce56c0d7..247ab15e530 100644
--- a/src/main/tmpl.c
+++ b/src/main/tmpl.c
@@ -642,7 +642,7 @@ int tmpl_afrom_value_box(TALLOC_CTX *ctx, vp_tmpl_t **out, value_box_t *data, bo
  * @param[in] list_def The default list to set if no #pair_lists qualifiers are found in
  *	name.
  * @param[in] allow_unknown If true attributes in the format accepted by
- *	#fr_dict_unknown_afrom_suboid will be allowed, even if they're not in the main
+ *	#fr_dict_unknown_afrom_oid_substr will be allowed, even if they're not in the main
  *	dictionaries.
  *	If an unknown attribute is found a #TMPL_TYPE_ATTR #vp_tmpl_t will be
  *	produced with the unknown #fr_dict_attr_t stored in the ``unknown.da`` buffer.